You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 02:27:12 UTC
[GitHub] [airflow] uma66 opened a new pull request #14184: Replace deprecated classes
uma66 opened a new pull request #14184:
URL: https://github.com/apache/airflow/pull/14184
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #14184: Replace deprecated classes
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #14184:
URL: https://github.com/apache/airflow/pull/14184#issuecomment-782254543
Replacing part of the SQLCheck operators is also covered here #12677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #14184: Replace deprecated classes
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #14184:
URL: https://github.com/apache/airflow/pull/14184#issuecomment-777256139
I think this should wait for end of March 2021 when we stop releasing Backport Packages. The deprecation removal in this case is not complete - it changes names of the operators, but it does not change the package (which is also deprecated). And this also means that it is "half" compatible - versions of Airflow released before July 2020 (This is when the rename was added) would not work with backport provider released with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14184: Replace deprecated classes
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14184:
URL: https://github.com/apache/airflow/pull/14184#issuecomment-777256139
I think this shoudl wait for end of March 2021 when we stop releasing Backport Packages. The deprecation removal in this case is not complete - it changes names of the operators, but it does not change the package (which is also deprecated). And this also means that it is "half" compatible - versions of Airflow released before July 2020 (This is when the rename was added) would not work with backport provider released with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uma66 commented on pull request #14184: Replace deprecated classes
Posted by GitBox <gi...@apache.org>.
uma66 commented on pull request #14184:
URL: https://github.com/apache/airflow/pull/14184#issuecomment-777426408
Thanks for pointing this out!
I thought this would be compatible because it only replaces the inheritance of the deprecation class with the parent class of the deprecation class, but does not remove the deprecation class itself.
Since that turned out to be a misconception, I am withdrawing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uma66 closed pull request #14184: Replace deprecated classes
Posted by GitBox <gi...@apache.org>.
uma66 closed pull request #14184:
URL: https://github.com/apache/airflow/pull/14184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org