You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by junichi11 <gi...@git.apache.org> on 2017/09/30 02:36:14 UTC
[GitHub] incubator-netbeans pull request #27: [NETBEANS-54] Module Review api.xml.ui
GitHub user junichi11 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/27
[NETBEANS-54] Module Review api.xml.ui
- no external library
- checked Rat report: add the license header to test/unit/src/org/netbeans/spi/xml/cookies/data/*, ignore org-netbeans-api-xml-ui.sig
- skimmed through the module, did not notice additional problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/junichi11/incubator-netbeans module-review-api.xml.ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 4f82952d953ab686328d9f8f5336ee10635f82b2
Author: Junichi Yamamoto <ju...@apache.org>
Date: 2017-09-30T02:24:09Z
[NETBEANS-54] Module Review api.xml.ui
----
---
[GitHub] incubator-netbeans issue #27: [NETBEANS-54] Module Review api.xml.ui
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/27
Looks good.
---
[GitHub] incubator-netbeans issue #27: [NETBEANS-54] Module Review api.xml.ui
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/27
Some extra newlines at the end but looks ok.
---
[GitHub] incubator-netbeans pull request #27: [NETBEANS-54] Module Review api.xml.ui
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/27
---