[jira] [Work logged] (BEAM-3194) Support annotating that a DoFn requires stable / deterministic input for replay/retry

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-3194?focusedWorklogId=135941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135941 ]

ASF GitHub Bot logged work on BEAM-3194:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Aug/18 00:41
            Start Date: 18/Aug/18 00:41
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #6220: [BEAM-3194] Add ValidatesRunner test for support of @RequiresStableInput
URL: https://github.com/apache/beam/pull/6220#discussion_r211057036
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/RetryFailures.java
 ##########
 @@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.testing;
+
+/** Category tag for tests that apply to runners that retry under failures. */
+public interface RetryFailures {}
 
 Review comment:
   Since your relying on runners to retry failures and support RequiresStableInput, I believe you should add the `UsesTransformThatRequiresStableInput` class as well. This would express the need for a runner to support both to run the tests. Currently your assuming that RetryFailures == Support for RequiresStableInput

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 135941)
    Time Spent: 20m  (was: 10m)

> Support annotating that a DoFn requires stable / deterministic input for replay/retry
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-3194
>                 URL: https://issues.apache.org/jira/browse/BEAM-3194
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Assignee: Yueyang Qiu
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> See the thread: https://lists.apache.org/thread.html/5fd81ce371aeaf642665348f8e6940e308e04275dd7072f380f9f945@%3Cdev.beam.apache.org%3E
> We need this in order to have truly cross-runner end-to-end exactly once via replay + idempotence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)