You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Kenney Westerhof (JIRA)" <ji...@codehaus.org> on 2005/09/12 16:04:02 UTC

[jira] Created: (MNG-868) Use uniform format for and other tags

Use uniform format for <properties> and other tags
--------------------------------------------------

         Key: MNG-868
         URL: http://jira.codehaus.org/browse/MNG-868
     Project: Maven 2
        Type: Bug
    Versions: 2.0-beta-1    
 Reporter: Kenney Westerhof
     Fix For: 2.0-beta-1


In settings.xml, the activationproperties have the format: <property><name/><value/></property>
whereas the 'user' properties below (which don't have any documentation) have the format
<my.property.name>my.property.value</my.property.name>.

They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.

There are more places where duplicate classes are used (repositories,..).

(Also suggest to remove the <dependencies> tag from <dependencyManagement>
and make DependencyManagement extend from Dependencies (or, make it a list)., but this
could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-868) Use uniform format for and other tags

Posted by "Maven Developers List (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-868?page=comments#action_55042 ] 

Maven Developers List commented on MNG-868:
-------------------------------------------

John, with your above comment then is this issue pretty much closed?

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug

>   Components: Design & Best Practices
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>     Assignee: John Casey
>     Priority: Trivial
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

Brett Porter updated MNG-868:
-----------------------------

    Fix Version:     (was: 2.0-beta-3)
                 2.1

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>     Assignee: John Casey
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

Jason van Zyl updated MNG-868:
------------------------------

    Priority: Trivial  (was: Major)

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug

>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>     Assignee: John Casey
>     Priority: Trivial
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

Brett Porter updated MNG-868:
-----------------------------

    Component: design

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-2

>
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-868) Use uniform format for and other tags

Posted by "John Didion (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-868?page=comments#action_56854 ] 

John Didion commented on MNG-868:
---------------------------------

This is also an issue for plugins that use properties. The plugin documentation states:

Properties

This category covers any map which implements java.util.Properties. These parameters are configured by including XML tags in the form <key>value</key> in the parameter configuration.

However, properties are actually configured using the <property><name/><value/></property> format.

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug

>   Components: Design, Patterns & Best Practices
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>     Assignee: John Casey
>     Priority: Trivial
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

John Casey updated MNG-868:
---------------------------

           Fix Version:     (was: 2.0-beta-3)
                        2.1
            Complexity: Expert  (was: Novice)
    Remaining Estimate: 2 hours
     Original Estimate: 7200

this would require a change to the .mdo files, which isn't going to happen until post-2.0-final, especially since it's not a bug.

We'll revisit syntax for 2.1, and apply lessons learned from 2.0 then.

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

Brett Porter updated MNG-868:
-----------------------------

    Fix Version:     (was: 2.0-beta-1)
                 2.0-beta-2

no more changes for beta-1

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-2

>
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

Brett Porter updated MNG-868:
-----------------------------

    Fix Version:     (was: 2.1)
                 2.0-beta-3

I haven't looked closely, but I think that this should be fixed while we still have the opportunity to do it. Otherwise we need to perpetually support it...

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-3

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-868) Use uniform format for and other tags

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-868?page=comments#action_47534 ] 

John Casey commented on MNG-868:
--------------------------------

The activation property is not the same as any old configuration parameter. For one thing, we're not (currently) supporting combinatorial logic for multiple properties, which means that using a flat MAP style is leaving the door open to problems of multiple property specification. Perhaps I'd better rename the activation property to <systemProperty>, where the separation is more clear.

In all other cases, properties are a map, or a DOM. In this case, I want the semantics to clearly support one property specification.

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug
>   Components: design
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-3

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-868) Use uniform format for and other tags

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-868?page=all ]

John Casey updated MNG-868:
---------------------------

    Assign To:     (was: John Casey)

> Use uniform format for <properties> and other tags
> --------------------------------------------------
>
>          Key: MNG-868
>          URL: http://jira.codehaus.org/browse/MNG-868
>      Project: Maven 2
>         Type: Bug

>   Components: Design, Patterns & Best Practices
>     Versions: 2.0-beta-1
>     Reporter: Kenney Westerhof
>     Priority: Trivial
>      Fix For: 2.1

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In settings.xml, the activationproperties have the format: <property><name/><value/></property>
> whereas the 'user' properties below (which don't have any documentation) have the format
> <my.property.name>my.property.value</my.property.name>.
> They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.
> There are more places where duplicate classes are used (repositories,..).
> (Also suggest to remove the <dependencies> tag from <dependencyManagement>
> and make DependencyManagement extend from Dependencies (or, make it a list)., but this
> could prove troublesome.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org