You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2012/05/10 12:53:54 UTC
[jira] [Created] (LUCENE-4048) Move getLines out of ResourceLoader
and require Charset
Chris Male created LUCENE-4048:
----------------------------------
Summary: Move getLines out of ResourceLoader and require Charset
Key: LUCENE-4048
URL: https://issues.apache.org/jira/browse/LUCENE-4048
Project: Lucene - Java
Issue Type: Improvement
Components: modules/analysis
Reporter: Chris Male
{{ResourceLoader.getLines()}} is only used by analysis factories. {{SolrResourceLoader}}'s implementation does the job well and it's unlikely that another {{ResourceLoader}} implementation would handle it differently.
We should extract the {{getLines()}} method out to {{AbstractAnalysisFactory}} so it can be used by the factories. Additionally we shouldn't assume the files are encoded in UTF-8, instead we should allow a Charset to be specified.
This would take us one step closer to reducing the {{ResourceLoader}} interface just to what it says, a loader of resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4048) Move getLines out of ResourceLoader
and require Charset
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-4048:
-------------------------------
Attachment: LUCENE-4048.patch
Patch with a bunch of nocommits for things I'm not happy about.
I've added the line reading functionality from {{SolrResourceLoader}} to WordlistLoader but I'm unsure that it belongs there since it's about reading the contents of generic resources, not just those related to stopwords.
What I'm thinking of doing is changing ResourceLoader to be an abstract class and putting the contents reading functionality there, and I can also put the boilerplate of integrating it with resources there too.
> Move getLines out of ResourceLoader and require Charset
> -------------------------------------------------------
>
> Key: LUCENE-4048
> URL: https://issues.apache.org/jira/browse/LUCENE-4048
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Chris Male
> Attachments: LUCENE-4048.patch
>
>
> {{ResourceLoader.getLines()}} is only used by analysis factories. {{SolrResourceLoader}}'s implementation does the job well and it's unlikely that another {{ResourceLoader}} implementation would handle it differently.
> We should extract the {{getLines()}} method out to {{AbstractAnalysisFactory}} so it can be used by the factories. Additionally we shouldn't assume the files are encoded in UTF-8, instead we should allow a Charset to be specified.
> This would take us one step closer to reducing the {{ResourceLoader}} interface just to what it says, a loader of resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4048) Move getLines out of ResourceLoader
and require Charset
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-4048:
-------------------------------
Attachment: LUCENE-4048.patch
Patch with all the nocommits fixed.
- ResourceLoader has become an abstract class with simple implementations for all its functionality.
- getLines() stays in ResourceLoader but now doesn't need to be re-implemented. Charset is now required
- I tied up some of code in AbstractAnalysisFactory which used ResourceLoader
- I nuked a bunch of ResourceLoader overrides since they weren't needed and there is a MockResourceLoader inside Solr's test-framework which does the job nicely.
> Move getLines out of ResourceLoader and require Charset
> -------------------------------------------------------
>
> Key: LUCENE-4048
> URL: https://issues.apache.org/jira/browse/LUCENE-4048
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Chris Male
> Attachments: LUCENE-4048.patch, LUCENE-4048.patch
>
>
> {{ResourceLoader.getLines()}} is only used by analysis factories. {{SolrResourceLoader}}'s implementation does the job well and it's unlikely that another {{ResourceLoader}} implementation would handle it differently.
> We should extract the {{getLines()}} method out to {{AbstractAnalysisFactory}} so it can be used by the factories. Additionally we shouldn't assume the files are encoded in UTF-8, instead we should allow a Charset to be specified.
> This would take us one step closer to reducing the {{ResourceLoader}} interface just to what it says, a loader of resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org