You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Luke Chen (Jira)" <ji...@apache.org> on 2020/06/08 03:05:00 UTC
[jira] [Updated] (KAFKA-10118) Improve stickiness verification for
AbstractStickyAssignorTest
[ https://issues.apache.org/jira/browse/KAFKA-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luke Chen updated KAFKA-10118:
------------------------------
Description:
In KAFKA-9987 , we implemented an optimized sticky partition assignor algorithm (i.e. {{constrainedAssign}} mehtod), so the original *isSticky* validation is not suitable for all situations, anymore. In this PR: [https://github.com/apache/kafka/pull/8788,] we removed the unnecessary isSticky verification for {{constrainedAssign}} method. But we should have a replace the check we removed with a better one. For more discussion, please see: [https://github.com/apache/kafka/pull/8788#pullrequestreview-425551903]
We haven't got any better idea so far, so welcome to provide suggestion. Thanks.
was:
In KAFKA-9987 , we implemented an optimized sticky partition assignor algorithm (i.e. {{constrainedAssign}} mehtod), so the original *isSticky* validation is not suitable for all situations. In this PR: [https://github.com/apache/kafka/pull/8788,] we removed the unnecessary isSticky verification for {{constrainedAssign}} method testing. But we should have a replace the check we removed with a better one. For more discussion, please see: [https://github.com/apache/kafka/pull/8788#pullrequestreview-425551903]
We haven't got any better idea so far, so welcome to provide suggestion. Thanks.
> Improve stickiness verification for AbstractStickyAssignorTest
> --------------------------------------------------------------
>
> Key: KAFKA-10118
> URL: https://issues.apache.org/jira/browse/KAFKA-10118
> Project: Kafka
> Issue Type: Test
> Reporter: Luke Chen
> Priority: Major
>
> In KAFKA-9987 , we implemented an optimized sticky partition assignor algorithm (i.e. {{constrainedAssign}} mehtod), so the original *isSticky* validation is not suitable for all situations, anymore. In this PR: [https://github.com/apache/kafka/pull/8788,] we removed the unnecessary isSticky verification for {{constrainedAssign}} method. But we should have a replace the check we removed with a better one. For more discussion, please see: [https://github.com/apache/kafka/pull/8788#pullrequestreview-425551903]
>
> We haven't got any better idea so far, so welcome to provide suggestion. Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)