You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2010/02/24 10:06:27 UTC
[jira] Created: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
libhdfs needs to be updated to use the new UGI
----------------------------------------------
Key: HDFS-1000
URL: https://issues.apache.org/jira/browse/HDFS-1000
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.22.0
libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877974#action_12877974 ]
Tom White commented on HDFS-1000:
---------------------------------
> we should commit the other jiras - HADOOP-6769 & HADOOP-6813 to 0.21
Done
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876796#action_12876796 ]
Devaraj Das commented on HDFS-1000:
-----------------------------------
If this patch is slated for 0.21, we should commit the other jiras - HADOOP-6769 & HADOOP-6813 to 0.21 as well..
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880437#action_12880437 ]
Hudson commented on HDFS-1000:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #314 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/314/])
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876535#action_12876535 ]
Hadoop QA commented on HDFS-1000:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12446548/hdfs-1000-trunk.1.patch
against trunk revision 951555.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/400/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/400/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/400/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/400/console
This message is automatically generated.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Attachment: hdfs-1000-trunk.1.patch
Patch for trunk. I ran the libhdfs unit test manually and it worked fine with the changes in this patch (I had to copy the bin directory from the Common repository in order to run the test).
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837945#action_12837945 ]
Eli Collins commented on HDFS-1000:
-----------------------------------
Minor comments:
* Needs additional tests, you already know that
* Need to check return values, eg cURI below. Know this is old code but good to fix it while you're at it.
{code}
+ cURI = malloc(strlen(host)+16);
+ sprintf(cURI, "hdfs://%s:%d", host, (int)(port));
{code}
* You should be able to remove HADOOP_UNIX_USER_GROUP_INFO now
* Some lines are > 80 cols
* Can remove some of the debug statements you added, eg:
{code}
+ System.out.println("GETCURRENTUSER CALLED");
{code}
* Have you checked that this doesn't introduce additional leaks, eg by looking at memory usage?
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876544#action_12876544 ]
Devaraj Das commented on HDFS-1000:
-----------------------------------
The test failures are unrelated. In fact the patch doesn't touch any Java source file..
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Attachment: fs-javadoc.patch
Attaching a patch that adds javadoc in the FileSystem class.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1000:
------------------------------
Fix Version/s: 0.21.0
Affects Version/s: 0.21.0
Priority: Blocker (was: Major)
Closing out HDFS-940 as a dupe of this one.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838092#action_12838092 ]
Suresh Srinivas commented on HDFS-1000:
---------------------------------------
Congrats on getting HDFS-1000 :-)
# Patch is only applicable for branch 0.20. Can you please also attach a patch for trunk?
# Patch does not apply to apache 0.20 branch.
# hdfs.c
#* HADOOP_USER_GROUP_INFO is not used
#* remove groups in the comment "conect with NULL as user name/groups".
#* properly indent {{goto done;}}
I tested the patch - previous tests no longer fail.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.3.patch, hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1000) libhdfs needs to be updated to use
the new UGI
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879584#action_12879584 ]
Suresh Srinivas commented on HDFS-1000:
---------------------------------------
+1 patch looks good.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Attachment: hdfs-1000-bp20.4.patch
Addresses the concerns Suresh had. The patch for trunk is coming soon.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Attachment: hdfs-1000-bp20.patch
This is a preliminary patch. Not passing the libhdfs tests yet (and has some debug messages).
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Attachment: hdfs-1000-bp20.3.patch
This patch addresses the minor comments from Eli. I also simplified the patch to do operations based on just the username (removed the groups thing). It doesn't make sense anymore since the group resolution happens on the server.
I don't think this requires new tests. An existing test covers the api i changed.
Also, this patch is for 20.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.3.patch, hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Status: Patch Available (was: Open)
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1000) libhdfs needs to be updated to use the
new UGI
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1000:
------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: (was: 0.22.0)
Resolution: Fixed
I just committed this.
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: fs-javadoc.patch, hdfs-1000-bp20.3.patch, hdfs-1000-bp20.4.patch, hdfs-1000-bp20.patch, hdfs-1000-trunk.1.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.