You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2018/04/02 15:22:57 UTC

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2618#discussion_r178567096
  
    --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
    @@ -497,7 +497,6 @@ static DynamicState cleanupCurrentContainer(DynamicState dynamicState, StaticSta
             assert(dynamicState.container.areAllProcessesDead());
             
             dynamicState.container.cleanUp();
    -        staticState.localizer.releaseSlotFor(dynamicState.currentAssignment, staticState.port);
    --- End diff --
    
    cleanupCurrentConatiner gets used in many different locations, not just during the blob update.  We need to release the slot when the container is killed or reference counting will be off.


---