You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Tommy Becker <tw...@gmail.com> on 2015/03/16 15:07:44 UTC
Review Request 32102: SAMZA-589
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32102/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
SAMZA-589
Diffs
-----
build.gradle 87334fa
samza-api/src/main/java/org/apache/samza/config/Config.java 9f7ade0
samza-api/src/main/java/org/apache/samza/config/MapConfig.java 1a83923
samza-api/src/test/java/org/apache/samza/config/TestConfig.java b4100c2
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 0afee64
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala 734d9d2
Diff: https://reviews.apache.org/r/32102/diff/
Testing
-------
Fix for SAMZA-589 - Need a way to flag sensitive information in Config.
This change adds a sanitize() method to Config that returns a new Config with values for keys beginning with "sensitive." masked. Config.toString() now operates on a sanitized copy. AM Web UI and API endpoints also use sanitized values.
Thanks,
Tommy Becker
Re: Review Request 32102: SAMZA-589
Posted by Tommy Becker <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32102/
-----------------------------------------------------------
(Updated March 16, 2015, 2:51 p.m.)
Review request for samza.
Changes
-------
Address review comments
Repository: samza
Description
-------
SAMZA-589
Diffs (updated)
-----
build.gradle 113da2a
docs/learn/documentation/versioned/jobs/configuration.md e094f60
samza-api/src/main/java/org/apache/samza/config/Config.java 9f7ade0
samza-api/src/main/java/org/apache/samza/config/MapConfig.java 1a83923
samza-api/src/test/java/org/apache/samza/config/TestConfig.java b4100c2
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 0afee64
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala 734d9d2
Diff: https://reviews.apache.org/r/32102/diff/
Testing
-------
Fix for SAMZA-589 - Need a way to flag sensitive information in Config.
This change adds a sanitize() method to Config that returns a new Config with values for keys beginning with "sensitive." masked. Config.toString() now operates on a sanitized copy. AM Web UI and API endpoints also use sanitized values.
Thanks,
Tommy Becker