You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hhuang1231 (via GitHub)" <gi...@apache.org> on 2024/03/14 05:10:19 UTC
[PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
hhuang1231 opened a new pull request, #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059
- upgrade jdk17 and springboot3
- upgrad to junit5
- Clean up commented out code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
Posted by "hhuang1231 (via GitHub)" <gi...@apache.org>.
hhuang1231 commented on PR #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059#issuecomment-1996909795
> Please check the comment here and update dependency in pom.xml [#1055 (comment)](https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996426918)
@chickenlj Now I have modified the module to follow the format of POM in #1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
Posted by "hhuang1231 (via GitHub)" <gi...@apache.org>.
hhuang1231 commented on code in PR #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059#discussion_r1524481163
##########
2-advanced/dubbo-samples-notify/dubbo-samples-notify-consumer/src/test/java/org/apache/dubbo/samples/notify/consumer/NotifyIT.java:
##########
@@ -17,31 +17,27 @@
package org.apache.dubbo.samples.notify.consumer;
+import jakarta.annotation.Resource;
import org.apache.dubbo.config.annotation.DubboReference;
import org.apache.dubbo.config.annotation.Method;
import org.apache.dubbo.samples.notify.DemoService;
-
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.springframework.beans.factory.annotation.Autowired;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.test.context.junit4.SpringRunner;
@SpringBootTest
-@RunWith(SpringRunner.class)
public class NotifyIT {
- // @DubboReference
+
@DubboReference(timeout = 6000, methods = @Method(name = "sayHello", onreturn = "notify.onReturn", onthrow = "notify.onThrow"))
private DemoService demoService;
- @Autowired
+ @Resource
Review Comment:
Sorry, this is my problem, I had revoked it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059#issuecomment-1996613901
Please check the comment here and update dependency in pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx commented on code in PR #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059#discussion_r1524283662
##########
2-advanced/dubbo-samples-notify/dubbo-samples-notify-consumer/src/test/java/org/apache/dubbo/samples/notify/consumer/NotifyIT.java:
##########
@@ -17,31 +17,27 @@
package org.apache.dubbo.samples.notify.consumer;
+import jakarta.annotation.Resource;
import org.apache.dubbo.config.annotation.DubboReference;
import org.apache.dubbo.config.annotation.Method;
import org.apache.dubbo.samples.notify.DemoService;
-
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.springframework.beans.factory.annotation.Autowired;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.test.context.junit4.SpringRunner;
@SpringBootTest
-@RunWith(SpringRunner.class)
public class NotifyIT {
- // @DubboReference
+
@DubboReference(timeout = 6000, methods = @Method(name = "sayHello", onreturn = "notify.onReturn", onthrow = "notify.onThrow"))
private DemoService demoService;
- @Autowired
+ @Resource
Review Comment:
Why did you change to use the resource annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-notify to jdk17 and spring3 [dubbo-samples]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #1059:
URL: https://github.com/apache/dubbo-samples/pull/1059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org