You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "dschneider-pivotal (GitHub)" <gi...@apache.org> on 2018/11/02 00:52:40 UTC
[GitHub] [geode] dschneider-pivotal opened pull request #2766:
removed field-mapping from jdbc:mapping
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #2766: removed
field-mapping from jdbc:mapping
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
I am not sure whether this `name` with an empty string is still required.
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #2766:
GEODE-5970: removed field-mapping from jdbc:mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2766:
GEODE-5970: removed field-mapping from jdbc:mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
I'm not sure either, but I do see other XmlType annotations (see CacheConfig and JndiBindingsType for examples) that do this same thing and it seems to be working so I'm going to keep it with the name "".
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #2766: removed
field-mapping from jdbc:mapping
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
After this field mapping section is deleted. The method should be renamed to reflect the fact that the columns are obtained from database metadata.
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2766:
GEODE-5970: removed field-mapping from jdbc:mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
I think this name is still good. The name does not say how it will map the field name to a column name; just that it does. In the future we may want to enhance this method to also look at other things and we should not need to change its names then.
[ Full content available at: https://github.com/apache/geode/pull/2766 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org