You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/09/15 12:57:30 UTC
[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2500
[FLINK-4549] [table] Test and document implicitly supported SQL functions
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR tests and documents all SQL functions that are currently supported. Things that are not documented are not supposed to work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink TableApiAllCalciteScalarFunctions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2500
----
commit 782fc7c09da25c44ecb61620acf2f7ce9d7077ad
Author: twalthr <tw...@apache.org>
Date: 2016-09-02T09:00:09Z
[FLINK-4549] [table] Test and document implicitly supported SQL functions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80237743
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala ---
@@ -545,7 +545,9 @@ class CodeGenerator(
generateInputAccess(input._1, input._2, index)
}
- override def visitFieldAccess(rexFieldAccess: RexFieldAccess): GeneratedExpression = ???
+ override def visitFieldAccess(rexFieldAccess: RexFieldAccess): GeneratedExpression =
+ throw new CodeGenException("The 'FieldAccess' feature is currently not supported.")
--- End diff --
This error message might not be very helpful. It does not tell a user what caused the problem and how it can be fixed. Would `"Nested field access is not support yet"` be better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80243251
--- Diff: docs/dev/table_api.md ---
@@ -2442,6 +3141,18 @@ object TimestampModifier extends ScalarFunction {
</div>
</div>
+### Limitations
+
+Not supported at all yet:
--- End diff --
"The following operations are not supported yet:"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80238320
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala ---
@@ -657,13 +659,17 @@ class CodeGenerator(
}
}
- override def visitCorrelVariable(correlVariable: RexCorrelVariable): GeneratedExpression = ???
+ override def visitCorrelVariable(correlVariable: RexCorrelVariable): GeneratedExpression =
+ throw new CodeGenException("The 'CorrelVariable' feature is currently not supported.")
--- End diff --
Same here and in the following added exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---