You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/16 08:42:18 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1108: [CALCITE-863] support RESPECT NULLS, IGNORE NULLS option for lead, lag function

zhztheplayer commented on a change in pull request #1108: [CALCITE-863] support RESPECT NULLS, IGNORE NULLS option for lead, lag function
URL: https://github.com/apache/calcite/pull/1108#discussion_r266194527
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java
 ##########
 @@ -106,6 +107,31 @@ protected SqlAggFunction(
         operandTypeChecker, null, funcType);
     this.requiresOrder = requiresOrder;
     this.requiresOver = requiresOver;
+    this.ignoreNulls = null;
 
 Review comment:
   Could you please check if we can deprecated this old constructor?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services