You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2018/02/25 08:31:37 UTC

wicket git commit: WICKET-6503 added test

Repository: wicket
Updated Branches:
  refs/heads/master 65fb29760 -> b728c69ad


WICKET-6503 added test


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b728c69a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b728c69a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b728c69a

Branch: refs/heads/master
Commit: b728c69ad42dcac9f9920ee811bdf1cc7014d0bb
Parents: 65fb297
Author: Sven Meier <sv...@apache.org>
Authored: Sun Feb 25 09:31:22 2018 +0100
Committer: Sven Meier <sv...@apache.org>
Committed: Sun Feb 25 09:31:22 2018 +0100

----------------------------------------------------------------------
 .../wicket/page/XmlPartialPageUpdateTest.java   | 23 ++++++++++++++++++++
 1 file changed, 23 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/b728c69a/wicket-core/src/test/java/org/apache/wicket/page/XmlPartialPageUpdateTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/page/XmlPartialPageUpdateTest.java b/wicket-core/src/test/java/org/apache/wicket/page/XmlPartialPageUpdateTest.java
index 3010945..a7570de 100644
--- a/wicket-core/src/test/java/org/apache/wicket/page/XmlPartialPageUpdateTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/page/XmlPartialPageUpdateTest.java
@@ -17,6 +17,7 @@
 package org.apache.wicket.page;
 
 import org.apache.wicket.Component;
+import org.apache.wicket.markup.html.basic.Label;
 import org.apache.wicket.markup.parser.filter.HtmlHeaderSectionHandler;
 import org.apache.wicket.mock.MockWebResponse;
 import org.apache.wicket.util.tester.WicketTestCase;
@@ -52,6 +53,7 @@ public class XmlPartialPageUpdateTest extends WicketTestCase
 				"</head>]]></header-contribution></ajax-response>";
 		assertEquals(expected, response.getTextResponse().toString());
 	}
+	
 	/**
 	 * 
 	 * see https://issues.apache.org/jira/browse/WICKET-6162
@@ -75,4 +77,25 @@ public class XmlPartialPageUpdateTest extends WicketTestCase
 		
 		assertEquals(originalHeader, page.get(HtmlHeaderSectionHandler.HEADER_ID));
 	}
+	
+	/**
+	 * WICKET-6503 removed components are not written, but no exception raised either. 
+	 */
+	@Test
+	public void removedComponentAreNotWritten() throws Exception
+	{
+		PageForPartialUpdate page = new PageForPartialUpdate();
+		
+		tester.startPage(page);
+		
+		XmlPartialPageUpdate update = new XmlPartialPageUpdate(page);		
+		
+		update.add(new Label("notInPage"), "notInPage");
+		
+		MockWebResponse response = new MockWebResponse();
+		
+		update.writeTo(response, "UTF-8");
+		
+		assertFalse("notInPage not written", response.getTextResponse().toString().contains("notInPage"));
+	}
 }