You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/09/30 12:10:10 UTC

[GitHub] storm pull request #2353: STORM-2648/STORM-2357 1.x

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2353

    STORM-2648/STORM-2357 1.x

    See https://github.com/apache/storm/pull/2249
    
    The first commit is a cherry pick of https://github.com/apache/storm/commit/48f6969027e7b02a5b9220577189d3911aa2226d, the second commit should contain the actual changes for this branch.
    
    I'll squash them before merging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2648-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2353
    
----
commit 24faf646e3102a6ed60f1e1aebfcefdb162598a2
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-07-31T18:26:55Z

    STORM-2648/STORM-2357: Add storm-kafka-client support for at-most-once processing and a toggle for whether messages should be emitted with a message id when not using at-least-once
    
    * Minor refactor of emit statements
    * Add tests for at-most-once and any-times mode, deduplicate some test code in other tests
    * Fix rebase conflicts and fix leaking state through unit test retry service
    * Update storm-kafka-client doc

commit 16acc0b117f9953600f819b61ffc41ff3b8ea2d0
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-09-30T12:06:18Z

    STORM-2648/STORM-2357: Backport to Java 7, minor change to KafkaSpoutConfig for backward compatibility

----


---

[GitHub] storm pull request #2353: STORM-2648/STORM-2357 1.x

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2353


---

[GitHub] storm issue #2353: STORM-2648/STORM-2357 1.x

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2353
  
    +1 
    @srdo Please squash and go ahead merging. Thanks!


---

[GitHub] storm issue #2353: STORM-2648/STORM-2357 1.x

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2353
  
    Thanks @HeartSaVioR.


---