You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/13 20:26:36 UTC
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6371
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
[DOCS] Genericize CREATE FUNCTION page
Several instances of things to revise on this page.
For example, com/cloudera in paths, -cdh570 in
filenames, and cloudera in github URLs.
There will still be some cloudera github URLs in the
HTML output after this change, but the source of the
CREATE FUNCTION page itself will be clean. (The URLs
in question will be edited in impala_keydefs.ditamap
as part of the endgame to revise various github URLs
related to UDF development.
Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
---
M docs/topics/impala_create_function.xml
1 file changed, 15 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/6371/1
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/73/
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize CREATE FUNCTION page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize CREATE FUNCTION page
......................................................................
[DOCS] Genericize CREATE FUNCTION page
Several instances of things to revise on this page.
For example, com/cloudera in paths, -cdh570 in
filenames, and cloudera in github URLs.
There will still be some cloudera github URLs in the
HTML output after this change, but the source of the
CREATE FUNCTION page itself will be clean. (The URLs
in question will be edited in impala_keydefs.ditamap
as part of the endgame to revise various github URLs
related to UDF development.
Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Reviewed-on: http://gerrit.cloudera.org:8080/6371
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_create_function.xml
1 file changed, 15 insertions(+), 18 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42fc2c59e744e43504ad92dc94f6659a59f49bd2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>