[GitHub] [ignite] korlov42 commented on a change in pull request #7797: IGNITE-13007: JDBC: Introduce feature flags for JDBC thin

[GitBox <gi...@apache.org>]

korlov42 commented on a change in pull request #7797:
URL: https://github.com/apache/ignite/pull/7797#discussion_r425753988



##########
File path: modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java
##########
@@ -1720,6 +1720,19 @@ public void testRollbackSavePoint() throws Exception {
         }
     }
 
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testDisabledFeatures() throws Exception {
+        assertInvalid(url + "?disabledFeatures=unknownFeature",
+            "Unknown feature: unknownFeature");
+
+        try (Connection conn = DriverManager.getConnection(url + "?disabledFeatures=reserved")) {

Review comment:
       No, it was done intentionally. This part verifies that with allowed parameters you could connects to the grid. I have added the comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org