[GitHub] [phoenix-queryserver] joshelser commented on a change in pull request #46: PHOENIX-5829 Make it possible to build/test queryserver against all s…

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #46:
URL: https://github.com/apache/phoenix-queryserver/pull/46#discussion_r463057659



##########
File path: phoenix-queryserver-it/pom.xml
##########
@@ -213,5 +175,92 @@
       <artifactId>bcprov-jdk15</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.google.code.gson</groupId>
+      <artifactId>gson</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
+
+  <profiles>
+    <!-- Phoenix 4.16.0-SNAPSHOT doesn't need special handling -->
+    <profile>
+      <id>phoenix-5.1.0-SNAPSHOT</id>
+      <activation>
+        <property>
+          <name>phoenix.version</name>
+          <value>5.1.0-SNAPSHOT</value>
+        </property>
+      </activation>

Review comment:
       Is there a reason to only have the activation for 5.1.0-SNAPSHOT?

##########
File path: README.md
##########
@@ -44,14 +44,12 @@ $ mvn package
 
 ### Bundling a Phoenix Client
 
-To build a release of PQS which packages a specific version of Phoenix, enable the `package-phoenix-client` profile
-and specify properties to indicate a specific Phoenix version.
+To build a release of PQS which packages a specific version of Phoenix, specify the `package-phoenix-client` system property
+and specify the `phoenix.version` system property to indicate a specific Phoenix version.
 
-By default, PQS will package the same version of Phoenix used for build/test. This version is controlled by the system
-property `phoenix.version` system property. Depending on the version of Phoenix, you may also be required to
-use the `phoenix.hbase.classifier` system property to identify the correct version of Phoenix built against
-the version of HBase of your choosing.
+PQS will package the same version of Phoenix used for build/test. This version is controlled by the
+ `phoenix.version` system property.

Review comment:
       If we don't have activation for all profiles off of phoenix.version values, we should call out the need to explicitly provide the profile.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org