You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/10/26 05:06:48 UTC

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service

wwbmmm commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005227617


##########
src/brpc/builtin/prometheus_metrics_service.cpp:
##########
@@ -200,6 +200,13 @@ int DumpPrometheusMetricsToIOBuf(butil::IOBuf* output) {
         return -1;
     }
     os.move_to(*output);
+
+    PrometheusMetricsDumper dumper_md(&os, g_server_info_prefix);

Review Comment:
   建议加个参数控制下，因为多维度的数据条目可能非常多，默认全部输出不合适



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org