You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by wenweihu86 <gi...@git.apache.org> on 2017/09/16 07:36:40 UTC
[GitHub] incubator-rocketmq pull request #165: fix DefaultMessageStoreTest bug: wait ...
GitHub user wenweihu86 opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/165
fix DefaultMessageStoreTest bug: wait more time for consume queue build
when run DefaultMessageStoreTest::testPullSize, it should wait more time to build consume queue.
The sleep time should be great than commit log flush interval plus consume queue flush interval.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wenweihu86/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
----
---
[GitHub] incubator-rocketmq issue #165: fix DefaultMessageStoreTest bug: wait more ti...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/165
@wenweihu86 Yeah. I have run it on Mac many times, and all results are successful. What environment do you run it on ?
---
[GitHub] incubator-rocketmq issue #165: fix DefaultMessageStoreTest bug: wait more ti...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/165
[](https://coveralls.io/builds/13299207)
Coverage increased (+0.03%) to 38.742% when pulling **a7c03c07c782cf7f728450b0cf094d0f48814d9c on wenweihu86:master** into **db00885d536993b32dadb9b4e26be86a32c740aa on apache:master**.
---
[GitHub] incubator-rocketmq issue #165: fix DefaultMessageStoreTest bug: wait more ti...
Posted by wenweihu86 <gi...@git.apache.org>.
Github user wenweihu86 commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/165
@dongeforever The unit test of DefaultMessageStoreTest::testPullSize run failed for 10ms in my environment. Could you run successful?
---
[GitHub] incubator-rocketmq issue #165: fix DefaultMessageStoreTest bug: wait more ti...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/165
@wenweihu86 By default, the commitlog will flush in real-time. If enable flushCommitLogTimed, then it will flush at the interval.
So there is no need to sleep 100 ms, 10 is enough, just for the building time of consume queue.
---