You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jdye64 <gi...@git.apache.org> on 2018/08/09 13:36:24 UTC
[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event
GitHub user jdye64 opened a pull request:
https://github.com/apache/nifi-registry/pull/134
NIFIREG-192: Implement REGISTRY_START event
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdye64/nifi-registry NIFIREG-192
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 06c89db48d77ebaf408128c893c97f4c9fccb17c
Author: Jeremy Dyer <je...@...>
Date: 2018-08-09T02:37:12Z
NIFIREG-192: Implement REGISTRY_START event
----
---
[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi-registry/pull/134
Same here - code LGTM, will give it a try today or tomorrow if no one has the cycles to do it before.
---
[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/134#discussion_r208977230
--- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/NiFiRegistryResourceConfig.java ---
@@ -44,6 +48,14 @@
private static final Logger logger = LoggerFactory.getLogger(NiFiRegistryResourceConfig.class);
+ @Autowired
+ private StandardProviderFactory standardProviderFactory;
+
+ @Bean
+ public EventService eventService() {
--- End diff --
I don't think this is required because `EventService` is already annotated with `@Service`, so it will be created as a bean by component scanning.
---
[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event
Posted by jdye64 <gi...@git.apache.org>.
Github user jdye64 commented on the issue:
https://github.com/apache/nifi-registry/pull/134
Sure will. I will update that right now and make another commit
---
[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/134
@jdye64 Thanks for that change. Now that #133 is merged, could you updated the documentation to add your new `REGISTRY_START` event type to the _Whitelisted Event Type x_ property value table?
---
[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-registry/pull/134
---
[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/134
+1, looks good and verified event is triggered when expected. Thanks for the contribution @jdye64!
---
[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/134#discussion_r208965183
--- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/NiFiRegistryApiApplication.java ---
@@ -54,6 +63,15 @@ protected SpringApplicationBuilder configure(SpringApplicationBuilder applicatio
.properties(defaultProperties);
}
+ @PostConstruct
+ public void postConstruct() {
--- End diff --
I'm not sure when post construct gets called for a SpringApplicationBuilder. I don't think we want to fire the REGISTRY_START event until after the full application context is loaded, otherwise EventHookProvider consumers of that event type might not be loaded/ready yet.
Take a look at the `ApplicationListener<ApplicationReadyEvent>` interface, that could be a nice solution to this.
---