You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Joseph Pachod (JIRA)" <ji...@apache.org> on 2010/04/02 23:19:27 UTC
[jira] Created: (WICKET-2820) change the Checkbox's
onSelectionChanged to have a Boolean as the new selection
change the Checkbox's onSelectionChanged to have a Boolean as the new selection
-------------------------------------------------------------------------------
Key: WICKET-2820
URL: https://issues.apache.org/jira/browse/WICKET-2820
Project: Wicket
Issue Type: Improvement
Reporter: Joseph Pachod
Attachments: checkBoxOnSelectionChangedBoolean.txt
The checkbox is defined as class CheckBox extends FormComponent<Boolean>
However, onSelectionChanged works with an object.
It could easily changed to a Boolean, making it clearer.
I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...).
On a side note, the Javadoc for "onSelectionChanged" should also be corrected. It currently speaks of "dropdown list".
thanks in advance
joseph
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2820) change the Checkbox's
onSelectionChanged to have a Boolean as the new selection
Posted by "Joseph Pachod (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852966#action_12852966 ]
Joseph Pachod commented on WICKET-2820:
---------------------------------------
Just a side note, the javadoc for the onSelectionChanged could be improved. Currently it contains this sentence :
* Called when a option is selected of a dropdown list that wants to be notified of this event.
whereas it's the CheckBox class. This line could be safely removed (starting from 1.4.x).
> change the Checkbox's onSelectionChanged to have a Boolean as the new selection
> -------------------------------------------------------------------------------
>
> Key: WICKET-2820
> URL: https://issues.apache.org/jira/browse/WICKET-2820
> Project: Wicket
> Issue Type: Improvement
> Reporter: Joseph Pachod
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: checkBoxOnSelectionChangedBoolean.txt
>
>
> The checkbox is defined as class CheckBox extends FormComponent<Boolean>
> However, onSelectionChanged works with an object.
> It could easily changed to a Boolean, making it clearer.
> I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...).
> On a side note, the Javadoc for "onSelectionChanged" should also be corrected. It currently speaks of "dropdown list".
> thanks in advance
> joseph
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2820) change the Checkbox's
onSelectionChanged to have a Boolean as the new selection
Posted by "Joseph Pachod (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Pachod updated WICKET-2820:
----------------------------------
Attachment: checkBoxOnSelectionChangedBoolean.txt
a (very simple) patch for resolving the issue
> change the Checkbox's onSelectionChanged to have a Boolean as the new selection
> -------------------------------------------------------------------------------
>
> Key: WICKET-2820
> URL: https://issues.apache.org/jira/browse/WICKET-2820
> Project: Wicket
> Issue Type: Improvement
> Reporter: Joseph Pachod
> Attachments: checkBoxOnSelectionChangedBoolean.txt
>
>
> The checkbox is defined as class CheckBox extends FormComponent<Boolean>
> However, onSelectionChanged works with an object.
> It could easily changed to a Boolean, making it clearer.
> I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...).
> On a side note, the Javadoc for "onSelectionChanged" should also be corrected. It currently speaks of "dropdown list".
> thanks in advance
> joseph
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2820) change the Checkbox's
onSelectionChanged to have a Boolean as the new selection
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2820.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
Assignee: Igor Vaynberg
> change the Checkbox's onSelectionChanged to have a Boolean as the new selection
> -------------------------------------------------------------------------------
>
> Key: WICKET-2820
> URL: https://issues.apache.org/jira/browse/WICKET-2820
> Project: Wicket
> Issue Type: Improvement
> Reporter: Joseph Pachod
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: checkBoxOnSelectionChangedBoolean.txt
>
>
> The checkbox is defined as class CheckBox extends FormComponent<Boolean>
> However, onSelectionChanged works with an object.
> It could easily changed to a Boolean, making it clearer.
> I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...).
> On a side note, the Javadoc for "onSelectionChanged" should also be corrected. It currently speaks of "dropdown list".
> thanks in advance
> joseph
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.