You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "wpiet (via GitHub)" <gi...@apache.org> on 2023/08/03 12:55:32 UTC
[GitHub] [mynewt-nimble] wpiet opened a new pull request, #1582: host/gap: add and update doxygen comments for the header file
wpiet opened a new pull request, #1582:
URL: https://github.com/apache/mynewt-nimble/pull/1582
Adds missing macros, functions and structures documentation. Corrects arguments names in functions documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1582: host/gap: add and update doxygen comments for the header file
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1582:
URL: https://github.com/apache/mynewt-nimble/pull/1582#discussion_r1285864618
##########
nimble/host/include/host/ble_gap.h:
##########
@@ -1286,7 +1471,7 @@ int ble_gap_adv_rsp_set_data(const uint8_t *data, int data_len);
* Configures the fields to include in subsequent advertisements. This is a
* convenience wrapper for ble_gap_adv_set_data().
*
- * @param adv_fields Specifies the advertisement data.
+ * @param rsp_fields Specifies the advertisement data.
Review Comment:
this should be left as adv_fields and function declaration should be updated to adv_fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1582: host/gap: add and update doxygen comments for the header file
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1582:
URL: https://github.com/apache/mynewt-nimble/pull/1582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org