You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/26 16:24:13 UTC
[GitHub] [ignite] map7000 opened a new pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
map7000 opened a new pull request #9131:
URL: https://github.com/apache/ignite/pull/9131
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] map7000 commented on a change in pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
Posted by GitBox <gi...@apache.org>.
map7000 commented on a change in pull request #9131:
URL: https://github.com/apache/ignite/pull/9131#discussion_r640429157
##########
File path: modules/ducktests/tests/ignitetest/tests/auth_test.py
##########
@@ -24,12 +24,13 @@
from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
from ignitetest.utils import ignite_versions, cluster
-from ignitetest.services.utils.ignite_configuration.discovery import from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import IgniteThinClientConfiguration
+from ignitetest.services.utils.ssl.client_connector_configuration import ClientConnectorConfiguration
from ignitetest.utils.ignite_test import IgniteTest
from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
WRONG_PASSWORD = "wrong_password"
-TEST_USERNAME = "admin"
+TEST_USERNAME = "ADMIN"
Review comment:
There are 2 ways to pass username in SQL query:
1. case-sensitive
"CREATE USER \"%s\" WITH PASSWORD '%s';"
2. not case-sensitive
"CREATE USER %s WITH PASSWORD '%s';"
IMHO variant 2 looks cleaner (but username should be uppercase)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9131:
URL: https://github.com/apache/ignite/pull/9131#discussion_r640452900
##########
File path: modules/ducktests/tests/ignitetest/tests/auth_test.py
##########
@@ -24,12 +24,13 @@
from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
from ignitetest.utils import ignite_versions, cluster
-from ignitetest.services.utils.ignite_configuration.discovery import from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import IgniteThinClientConfiguration
+from ignitetest.services.utils.ssl.client_connector_configuration import ClientConnectorConfiguration
from ignitetest.utils.ignite_test import IgniteTest
from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
WRONG_PASSWORD = "wrong_password"
-TEST_USERNAME = "admin"
+TEST_USERNAME = "ADMIN"
Review comment:
`TEST_USERNAME` implicitly connected with `UserModifyingApplication` - username should be in uppercase to work correctly.
It seems wrong connection.
Please, fix the app and add quotes to queries to make queries not related to parameter case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9131:
URL: https://github.com/apache/ignite/pull/9131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] map7000 commented on a change in pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
Posted by GitBox <gi...@apache.org>.
map7000 commented on a change in pull request #9131:
URL: https://github.com/apache/ignite/pull/9131#discussion_r640429157
##########
File path: modules/ducktests/tests/ignitetest/tests/auth_test.py
##########
@@ -24,12 +24,13 @@
from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
from ignitetest.utils import ignite_versions, cluster
-from ignitetest.services.utils.ignite_configuration.discovery import from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import IgniteThinClientConfiguration
+from ignitetest.services.utils.ssl.client_connector_configuration import ClientConnectorConfiguration
from ignitetest.utils.ignite_test import IgniteTest
from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
WRONG_PASSWORD = "wrong_password"
-TEST_USERNAME = "admin"
+TEST_USERNAME = "ADMIN"
Review comment:
There are 2 ways to pass username in SQL query:
1. case-sensitive
"CREATE USER \\"%s\\" WITH PASSWORD '%s';"
2. not case-sensitive
"CREATE USER %s WITH PASSWORD '%s';"
IMHO variant 2 looks cleaner (but username should be uppercase)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #9131: IGNITE-14786 Authentication ducktest should not use internal api
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #9131:
URL: https://github.com/apache/ignite/pull/9131#discussion_r640387523
##########
File path: modules/ducktests/tests/ignitetest/tests/auth_test.py
##########
@@ -24,12 +24,13 @@
from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
from ignitetest.utils import ignite_versions, cluster
-from ignitetest.services.utils.ignite_configuration.discovery import from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import IgniteThinClientConfiguration
+from ignitetest.services.utils.ssl.client_connector_configuration import ClientConnectorConfiguration
from ignitetest.utils.ignite_test import IgniteTest
from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
WRONG_PASSWORD = "wrong_password"
-TEST_USERNAME = "admin"
+TEST_USERNAME = "ADMIN"
Review comment:
why uppercase now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org