You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/11 12:31:19 UTC
[jira] Created: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
test failures in modules should be propogated back up to top level test target
------------------------------------------------------------------------------
Key: HARMONY-331
URL: http://issues.apache.org/jira/browse/HARMONY-331
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Priority: Minor
"ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=comments#action_12374147 ]
Mark Hindess commented on HARMONY-331:
--------------------------------------
Looks like you changed the indentation of the closing </echo> tags. This means that if you have failures in, for example, nio and sql, the build/test_report/test.failures file now contains:
nio
<tab><tab>sql
<tab><tab>
rather than just two neat lines:
nio
sql
The indentation you changed was intentional (if a little ugly). I was thinking that this file might actually be read by humans (or perhaps <concat>'d to the console by ant) so I thought keeping it tidy was worth the cost of the ugly indentation.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=all ]
Mark Hindess updated HARMONY-331:
---------------------------------
Attachment: make.ant.test.target.fail.diff
Patch modified the module build files to append the name of the module to a list of modules with errors or failures that is then check for by the top level test target.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=comments#action_12374151 ]
Stepan Mishura commented on HARMONY-331:
----------------------------------------
What about adding message parameter, for example:
<target name="touch-failures-file" if="test.failures">
<echo file="${hy.tests.reports}/test.failures"
append="true"
message="applet"/>
</target>
I think this will resolve the problem with tabs in test.failures file
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=comments#action_12374163 ]
Stepan Mishura commented on HARMONY-331:
----------------------------------------
Mark, thank you for your comments - indentation in result files fixed at at repo revision 393421.
Please check that this fully resolves your problem.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=all ]
Mark Hindess updated HARMONY-331:
---------------------------------
Attachment: working.make.ant.test.target.fail.diff
Oops. Fixing spurious </echo> tags in modules/luni/make/common/build.xml in previous patch.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=all ]
Stepan Mishura closed HARMONY-331:
----------------------------------
Verified by Mark.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=comments#action_12374154 ]
Mark Hindess commented on HARMONY-331:
--------------------------------------
It solves the tab problem, but now the file has no newlines, just "niosql". ;-)
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=comments#action_12374169 ]
Mark Hindess commented on HARMONY-331:
--------------------------------------
That seems right now. Thanks very much for trying to find a more elegant way. I appreciated it even if it didn't work out this time.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=all ]
Stepan Mishura reassigned HARMONY-331:
--------------------------------------
Assign To: Stepan Mishura
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-331) test failures in modules should be
propogated back up to top level test target
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-331?page=all ]
Stepan Mishura resolved HARMONY-331:
------------------------------------
Resolution: Fixed
Thanks Mark,
Patch was applied at repo revision 393409. (I've changed indentation only)
Please check that the patch was applied as you expected.
> test failures in modules should be propogated back up to top level test target
> ------------------------------------------------------------------------------
>
> Key: HARMONY-331
> URL: http://issues.apache.org/jira/browse/HARMONY-331
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: make.ant.test.target.fail.diff, working.make.ant.test.target.fail.diff
>
> "ant -f make/build.xml test" should run all tests but fail at the end if any test fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira