You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/07 12:12:24 UTC
[GitHub] [solr-operator] mmoscher opened a new pull request #413: Fixes incoherent varibale naming for additional domain names
mmoscher opened a new pull request #413:
URL: https://github.com/apache/solr-operator/pull/413
Fixes #412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #413: Fixes incoherent variable naming for additional domain names
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #413:
URL: https://github.com/apache/solr-operator/pull/413#issuecomment-1063228821
Closing this in favor of #415 and #416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #413: Fixes incoherent variable naming for additional domain names
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #413:
URL: https://github.com/apache/solr-operator/pull/413#issuecomment-1062255919
How about this?
- For `v0.5.1` update the documentation
- For `v0.6.0` add the new field, and auto-populate with the value from the old field. Add upgrade notes, deprecate the old field.
- For `v0.7.0` remove the old field from the CRD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #413: Fixes incoherent variable naming for additional domain names
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #413:
URL: https://github.com/apache/solr-operator/pull/413#issuecomment-1062048828
Unfortunately we can't really break back-compat like that. Either we need to:
- Have 2 fields, and pre-populate the new `additionalDomainNames` field with the old `additionalDomains` value. We can deprecate the `additionalDomains` option and remove it in a future release.
- Fix the documentation to use `additionalDomains` and call it a day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman closed pull request #413: Fixes incoherent variable naming for additional domain names
Posted by GitBox <gi...@apache.org>.
HoustonPutman closed pull request #413:
URL: https://github.com/apache/solr-operator/pull/413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org