You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/07/03 07:19:34 UTC
[PR] AWS: Apply glue/kms endpoint overrides in AssumeRoleAwsClientFactory [iceberg]
thswlsqls opened a new pull request, #17049:
URL: https://github.com/apache/iceberg/pull/17049
Closes #17047
## Summary
- `AssumeRoleAwsClientFactory.glue()`/`.kms()` did not apply the `glue.endpoint`/`kms.endpoint` overrides configured via `AwsProperties`, unlike their `dynamo()` sibling in the same class, which already calls `applyMutation(awsProperties::applyDynamoDbEndpointConfigurations)`.
- `AwsClientFactories.DefaultAwsClientFactory.glue()`/`.kms()` already apply these endpoint overrides; this change restores parity for the assume-role code path.
- `LakeFormationAwsClientFactory.kms()` (registered-table branch) had the same gap and is fixed the same way; its `glue()` is inherited from `AssumeRoleAwsClientFactory` and needed no separate change.
- `glue.endpoint`/`kms.endpoint` remain no-ops when unset (`AwsProperties#configureEndpoint` only calls `endpointOverride()` when the property is non-null), so behavior for existing users without these properties is unchanged.
## Testing done
- Added `TestAwsClientFactories#testAssumeRoleGlueClientAppliesEndpointOverride`, `#testAssumeRoleKmsClientAppliesEndpointOverride` (assert `serviceClientConfiguration().endpointOverride()` equals the configured URI), and `#testAssumeRoleGlueKmsClientEndpointOverrideIsNoopByDefault` (asserts empty override when unset).
- Added `TestLakeFormationAwsClientFactory#testKmsClientAppliesEndpointOverrideForRegisteredTable`, stubbing `glue()` with a mocked `GlueClient` to make the registered-table branch of `kms()` reachable without Docker/network access.
- `./gradlew :iceberg-aws:check -x integrationTest` — 225 tests passed (integrationTest requires Docker/testcontainers and was not run locally, per project convention).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Apply glue/kms endpoint overrides in AssumeRoleAwsClientFactory [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17049:
URL: https://github.com/apache/iceberg/pull/17049#issuecomment-5363599923
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Apply glue/kms endpoint overrides in AssumeRoleAwsClientFactory [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17049: AWS: Apply glue/kms endpoint overrides in AssumeRoleAwsClientFactory
URL: https://github.com/apache/iceberg/pull/17049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Apply glue/kms endpoint overrides in AssumeRoleAwsClientFactory [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17049:
URL: https://github.com/apache/iceberg/pull/17049#issuecomment-5447802399
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org