You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/01/15 07:03:58 UTC

[GitHub] [submarine] yaooqinn commented on a change in pull request #490: SUBMARINE-638. [Spark-Security]Apply global/local limit after masking projection

yaooqinn commented on a change in pull request #490:
URL: https://github.com/apache/submarine/pull/490#discussion_r557923844



##########
File path: submarine-security/spark-security/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SubmarineDataMaskingExtension.scala
##########
@@ -233,7 +233,20 @@ case class SubmarineDataMaskingExtension(spark: SparkSession) extends Rule[Logic
         case p if hasCatalogTable(p) => SubmarineDataMasking(p)
       }
 
-      marked transformAllExpressions {
+      // Extract global/local limit if any and apply after masking projection
+      val limitExpr: Option[Expression] = plan match {
+        case unaryNode: UnaryNode =>
+          unaryNode match {

Review comment:
       redundant here？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org