You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "etseidl (via GitHub)" <gi...@apache.org> on 2024/09/05 22:42:18 UTC
Re: [I] warning: methods `as_any` and `next_batch` are never used in `parquet` crate [arrow-rs]
etseidl commented on issue #6143:
URL: https://github.com/apache/arrow-rs/issues/6143#issuecomment-2332799982
I've been playing around with this, and found that `next_batch` is only used in benchmarks and tests, while `as_any` truly does seem to be completely unused. For `next_batch` we can add `#[cfg(any(feature = "experimental", test))]` to silence the warning. For `as_any`, we could either remove it (it appears unused, and `array_reader` does not appear to be public), or simply allow dead code if we think `as_any` might be of use down the road. We could also just throw `#[allow(dead_code)]` on both. @alamb any preferences here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org