You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2010/12/20 19:45:44 UTC
Re: svn commit: r1051164 - /subversion/trunk/subversion/libsvn_ra/util.c
cmpilato@apache.org writes:
> Author: cmpilato
> Date: Mon Dec 20 16:07:08 2010
> New Revision: 1051164
>
> URL: http://svn.apache.org/viewvc?rev=1051164&view=rev
> Log:
> Another follow-up to r1050216.
>
> * subversion/libsvn_ra/util.c
> (svn_ra__release_operational_lock): Switch the sense of the boolean
> return from svn_string_compare(). I forgot that it returns TRUE for
> "matches", the opposite of the previous strcmp() code that was in place.
The original code did "strcmp() == 0" so "matches" was TRUE there as
well.
--
Philip
Re: svn commit: r1051164 - /subversion/trunk/subversion/libsvn_ra/util.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 12/20/2010 02:45 PM, Philip Martin wrote:
> cmpilato@apache.org writes:
>
>> Author: cmpilato
>> Date: Mon Dec 20 16:07:08 2010
>> New Revision: 1051164
>>
>> URL: http://svn.apache.org/viewvc?rev=1051164&view=rev
>> Log:
>> Another follow-up to r1050216.
>>
>> * subversion/libsvn_ra/util.c
>> (svn_ra__release_operational_lock): Switch the sense of the boolean
>> return from svn_string_compare(). I forgot that it returns TRUE for
>> "matches", the opposite of the previous strcmp() code that was in place.
>
> The original code did "strcmp() == 0" so "matches" was TRUE there as
> well.
Doh! That's what I get for reading the code too quickly. (Thanks for the
review, Philip.)
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand