You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/11/18 13:51:20 UTC
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1376
[FLINK-1945][py] Python Tests less verbose
Tests now extend from JavaProgramTestBase, were consolidated into less files to reduce build time, and restructured to not be utterly chaotic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 1945_pytest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1376
----
commit 2132e0e82c86be1a7a1090fb7af5ba4388a20e62
Author: zentol <ch...@apache.org>
Date: 2015-11-18T11:52:42Z
[FLINK-1945][py] Python Tests less verbose
Tests now extend from JavaProgramTestBase, and were consolidated into less files to reduce build time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158016205
Great @zentol. Good to merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45240517
--- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py ---
@@ -58,5 +58,5 @@
msg.output()
--- End diff --
actually, given ow its currently run this could be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45221471
--- Diff: flink-libraries/flink-python/pom.xml ---
@@ -48,6 +48,14 @@ under the License.
</archive>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.17</version><!--$NO-MVN-MAN-VER$-->
+ <configuration>
+ <forkCount>1</forkCount>
--- End diff --
Why do we execute the Python tests sequentially?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-157772432
Changes look good. I had only a minor comment. Besides that +1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45221988
--- Diff: flink-libraries/flink-python/pom.xml ---
@@ -48,6 +48,14 @@ under the License.
</archive>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.17</version><!--$NO-MVN-MAN-VER$-->
+ <configuration>
+ <forkCount>1</forkCount>
--- End diff --
uhh...i think something broke otherwise. Let me try it real quick and see what happens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158015146
@tillrohrmann I've changed the type deduction test to a) no longer produce any output and b) actually fail with an exception f things go wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45224052
--- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py ---
@@ -58,5 +58,5 @@
msg.output()
--- End diff --
Do we need this output here? Is it important to decide whether the test passed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1376#issuecomment-158042693
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45227781
--- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py ---
@@ -58,5 +58,5 @@
msg.output()
--- End diff --
it's not needed, but the JavaProgramTestBase expects a job to be run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1376#discussion_r45222496
--- Diff: flink-libraries/flink-python/pom.xml ---
@@ -48,6 +48,14 @@ under the License.
</archive>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.17</version><!--$NO-MVN-MAN-VER$-->
+ <configuration>
+ <forkCount>1</forkCount>
--- End diff --
scratch that, works without it as well. gonna remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---