You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/04 23:30:57 UTC

[GitHub] [iceberg] dilipbiswal commented on a change in pull request #2021: Add the cardinality check to detect ambiguous target row for MERGE INTO

dilipbiswal commented on a change in pull request #2021:
URL: https://github.com/apache/iceberg/pull/2021#discussion_r551629640



##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDelete.scala
##########
@@ -77,7 +61,7 @@ object RewriteDelete extends Rule[LogicalPlan] with PredicateHelper with Logging
       val writeInfo = newWriteInfo(r.schema)
       val mergeBuilder = r.table.asMergeable.newMergeBuilder("delete", writeInfo)
 
-      val scanPlan = buildScanPlan(r.table, r.output, mergeBuilder, cond)
+      val scanPlan = buildScanPlan(spark, r.table, r.output, mergeBuilder, Some(cond))

Review comment:
       @rdblue Okay Ryan.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org