[jira] [Comment Edited] (TS-2504) Fix crypto.m4 when detect openssl library in 64bit OS

["Yunkai Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880703#comment-13880703 ] 

Yunkai Zhang edited comment on TS-2504 at 1/24/14 6:23 PM:
-----------------------------------------------------------

[~jamespeach]:

It seems there is a bug in this patch.

1) Our OpenSSL was installed in '/home/a/' DIR, and its library directory is '/home/a/lib64/'.

2) By using this patch(in the latest master branch),  compiles ATS with following options:
{code}
[root@test79 trafficserver]# cat config.nice
#! /bin/sh
#
# Created by configure

"./configure" \
"--enable-layout=Gentoo" \
"--with-user=ats" \
"--with-group=ats" \
"--with-openssl=/home/a" \
"$@"
{code}

3) From config.log, we can see that it can detect OpenSSL, but didn't use correct CFLAGS/LDFLAGS to check OpenSSL functions:
{code}
configure:23731: checking for openssl/ssl.h in /home/a
configure:23742: result: yes
configure:23758: checking whether compiling and linking against OpenSSL works
Trying link with OPENSSL_LDFLAGS=-L/home/a/lib64; OPENSSL_LIBS=-lssl -lcrypto; OPENSSL_INCLUDES=-I/home/a/include
configure:23790: cc -o conftest -g -pipe -Wall -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -I/home/a/include -Dlinux -D_LARGEFILE64_SOURCE=1 -D>
configure:23797: $? = 0
configure:23806: result: yes
configure:23915: checking for SSL_CTX_set_next_protos_advertised_cb
configure:23971: cc -o conftest -g -pipe -Wall -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Dlinux -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOUR>
/tmp/cc1jswre.o: In function `main':
/root/yunkai/trafficserver/conftest.c:70: undefined reference to `SSL_CTX_set_next_protos_advertised_cb'
collect2: ld returned 1 exit status
{code}


was (Author: yunkai):
It seems there is a bug in this patch.

1) Our OpenSSL was installed in '/home/a/' DIR, and its library directory is '/home/a/lib64/'.

2) By using this patch(in the latest master branch),  compiles ATS with following options:
{code}
[root@test79 trafficserver]# cat config.nice
#! /bin/sh
#
# Created by configure

"./configure" \
"--enable-layout=Gentoo" \
"--with-user=ats" \
"--with-group=ats" \
"--with-openssl=/home/a" \
"$@"
{code}

3) From config.log, we can see that it can detect OpenSSL, but didn't use correct CFLAGS/LDFLAGS to check OpenSSL functions:
{code}
configure:23731: checking for openssl/ssl.h in /home/a
configure:23742: result: yes
configure:23758: checking whether compiling and linking against OpenSSL works
Trying link with OPENSSL_LDFLAGS=-L/home/a/lib64; OPENSSL_LIBS=-lssl -lcrypto; OPENSSL_INCLUDES=-I/home/a/include
configure:23790: cc -o conftest -g -pipe -Wall -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -I/home/a/include -Dlinux -D_LARGEFILE64_SOURCE=1 -D>
configure:23797: $? = 0
configure:23806: result: yes
configure:23915: checking for SSL_CTX_set_next_protos_advertised_cb
configure:23971: cc -o conftest -g -pipe -Wall -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Dlinux -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOUR>
/tmp/cc1jswre.o: In function `main':
/root/yunkai/trafficserver/conftest.c:70: undefined reference to `SSL_CTX_set_next_protos_advertised_cb'
collect2: ld returned 1 exit status
{code}

> Fix crypto.m4 when detect openssl library in 64bit OS
> -----------------------------------------------------
>
>                 Key: TS-2504
>                 URL: https://issues.apache.org/jira/browse/TS-2504
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: Yunkai Zhang
>            Assignee: James Peach
>             Fix For: 4.2.0
>
>
> From [~jamespeach]:
> {quote}
> Yunkai Zhang can you split 0007-Fix-crypto.m4-when-detect-openssl-library-in-64bit-O.V2.patch into a separate Jira ticket? 
> Shall we use http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_check_openssl.m4 to improve OpenSSL detection?
> {quote}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)