You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/09/23 04:00:20 UTC
[GitHub] incubator-gearpump pull request #88: [GEARPUMP-213] build with mkdocs
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/88
[GEARPUMP-213] build with mkdocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump new_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 9e13c1e6fa2466a71f59cb9a7339202304d268bc
Author: manuzhang <ow...@gmail.com>
Date: 2016-09-20T02:14:20Z
[GEARPUMP-213] build with mkdocs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build docs with MkDocs
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
I'm OK with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build docs with MkDocs
Posted by whjiang <gi...@git.apache.org>.
Github user whjiang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #88: [GEARPUMP-213] build docs with MkDocs
Posted by whjiang <gi...@git.apache.org>.
Github user whjiang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/88#discussion_r81069120
--- Diff: docs/docs/deployment/deployment-msg-delivery.md ---
@@ -0,0 +1,60 @@
+## How to deploy for At Least Once Message Delivery?
--- End diff --
why this file is under docs/docs/deployment instead of one "docs"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #88: [GEARPUMP-213] build docs with MkDocs
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/88#discussion_r81069516
--- Diff: docs/docs/deployment/deployment-msg-delivery.md ---
@@ -0,0 +1,60 @@
+## How to deploy for At Least Once Message Delivery?
--- End diff --
inner `docs` is the default source directory used by MkDocs and all documentations are under the outer `docs` directory
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build with mkdocs
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/88?src=pr) is 71.09% (diff: 100%)
> Merging [#88](https://codecov.io/gh/apache/incubator-gearpump/pull/88?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.28%**
```diff
@@ master #88 diff @@
==========================================
Files 178 178
Lines 5903 5903
Methods 5584 5398 -186
Messages 0 0
Branches 319 505 +186
==========================================
+ Hits 4180 4197 +17
+ Misses 1723 1706 -17
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [5cd5b93...9e13c1e](https://codecov.io/gh/apache/incubator-gearpump/compare/5cd5b9304f0f703c6f89d2865e5bb7adbb631c74...9e13c1e6fa2466a71f59cb9a7339202304d268bc?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build docs with MkDocs
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
+1 - though i haven't seen the output
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build with mkdocs
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
@whjiang @kkasravi @huafengw what do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---