[GitHub] [helix] alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409)

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #410: Fix the execution delay for the jobs (409)
URL: https://github.com/apache/helix/pull/410#discussion_r314384444
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
 ##########
 @@ -165,7 +165,9 @@ public void updateWorkflowStatus(String workflow, WorkflowConfig workflowCfg,
     RuntimeJobDag runtimeJobDag = _clusterDataCache.getTaskDataCache().getRuntimeJobDag(workflow);
     if (runtimeJobDag != null) {
       for (String inflightJob : runtimeJobDag.getInflightJobList()) {
-        processJob(inflightJob, currentStateOutput, bestPossibleOutput, workflowCtx);
+        if (System.currentTimeMillis() >= workflowCtx.getJobStartTime(inflightJob)) {
 
 Review comment:
   Thank you for your comments.
   1- Based on same logic that is added few line below (which calculates the start time and store these information and process the job if possible), this is the place that this check should happen. (same as the scheduleJobs method in WorkflowDistpatcher).
   2- About the comprehensive change, I agree with you. This is just a quick fix. We will need to revisit several concepts such as inflight jobs and retry delay. I am working on the retry delay and will create new issue for that as well. After that we can think on a comprehensive changes to the Task Framework.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org