You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/03/12 06:46:52 UTC

Re: Review Request 31526: CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31526/
-----------------------------------------------------------

(Updated March 12, 2015, 11:16 a.m.)


Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri.


Summary (updated)
-----------------

CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted.


Bugs: CLOUDSTACK-8290
    https://issues.apache.org/jira/browse/CLOUDSTACK-8290


Repository: cloudstack-git


Description (updated)
-------

Steps that should be added to verify absence of the defect.

1. Create a VM in an isolated network
2. Acquire a public IP in the network
3. Enable static NAT rule / LB rule / NAT rule for the IP
4. Check we are able to SSH to VM
5. Check the "ip addr" command output on VR, the rules should be present on VR for the public IP
6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP
7. Check SSH to VM, it should fail
8. Check the "ip addr" command output on VR, the rules should now not be present on VR for the public IP


Diffs
-----

  test/integration/smoke/test_network.py cca1803 
  tools/marvin/marvin/codes.py a7e8ec8 

Diff: https://reviews.apache.org/r/31526/diff/


Testing
-------

Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS
===
ok
Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
SUCCESS ===
ok

----------------------------------------------------------------------
Ran 3 tests in 409.871s

OK


Thanks,

Gaurav Aradhye


Re: Review Request 31526: CLOUDSTACK-8290: Adding BVT to verify public IP data is removed from router once network rule is deleted.

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31526/#review76215
-----------------------------------------------------------

Ship it!


ff9ab5caa96f4b3cac9eabf08034ce40c4b389be master

- SrikanteswaraRao Talluri


On March 12, 2015, 5:46 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31526/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 5:46 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8290
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8290
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Steps that should be added to verify absence of the defect.
> 
> 1. Create a VM in an isolated network
> 2. Acquire a public IP in the network
> 3. Enable static NAT rule / LB rule / NAT rule for the IP
> 4. Check we are able to SSH to VM
> 5. Check the "ip addr" command output on VR, the rules should be present on VR for the public IP
> 6. Disable static NAT / Delete NAT/ LB Rule or disassociate public IP
> 7. Check SSH to VM, it should fail
> 8. Check the "ip addr" command output on VR, the rules should now not be present on VR for the public IP
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py cca1803 
>   tools/marvin/marvin/codes.py a7e8ec8 
> 
> Diff: https://reviews.apache.org/r/31526/diff/
> 
> 
> Testing
> -------
> 
> Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS
> ===
> ok
> Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
> ok
> Test for Static NAT rule for acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
> SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 409.871s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>