You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2023/01/30 07:36:38 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8347: tools: compile with full file path
Gary-Hobson opened a new pull request, #8347:
URL: https://github.com/apache/nuttx/pull/8347
## Summary
When compiling errors before, only a simple file path and sum will be prompted, and it may be troublesome for us to find it.
Now use the full path and this problem will not exist
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8347: tools: compile with full file path
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8347:
URL: https://github.com/apache/nuttx/pull/8347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #8347: tools: compile with full file path
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #8347:
URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1409829481
> @Gary-Hobson this patch need rebase
Doneļ¼ need to merge https://github.com/apache/nuttx-apps/pull/1515 before merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8347: tools: compile with full file path
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8347:
URL: https://github.com/apache/nuttx/pull/8347#discussion_r1091719602
##########
tools/Config.mk:
##########
@@ -364,7 +364,7 @@ endef
define ASSEMBLE
@echo "AS: $1"
- $(Q) $(CCACHE) $(CC) -c $(AFLAGS) $1 $($(strip $1)_AFLAGS) -o $2
+ $(Q) $(CCACHE) $(CC) -c $(AFLAGS) $(abspath $1) $($(strip $1)_AFLAGS) -o $(abspath $2)
Review Comment:
please create a new patch to algin with other:
```suggestion
$(Q) $(CCACHE) $(CC) -c $(AFLAGS) $($(strip $1)_AFLAGS) $(abspath $1) -o $(abspath $2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8347: tools: compile with full file path
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8347:
URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1409813266
@Gary-Hobson this patch need rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8347: tools: compile with full file path
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8347:
URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1410069856
Need update ELFCOMPILE in apps too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8347: tools: compile with full file path
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8347:
URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1408126947
let's merge the last two patch into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org