You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/08 07:06:08 UTC
[GitHub] mistercrunch commented on issue #6836: [question]
SUPERSET_WEBSERVER_TIMEOUT deprecated but what is the alternative?
mistercrunch commented on issue #6836: [question] SUPERSET_WEBSERVER_TIMEOUT deprecated but what is the alternative?
URL: https://github.com/apache/incubator-superset/issues/6836#issuecomment-461710957
Looks like this is confusing indeed, the comment comes from https://github.com/apache/incubator-superset/pull/4451 where the auto generated `gunicorn` command (started through `superset runserver`) started getting deprecation messages but appears to still work.
The config element `SUPERSET_WEBSERVER_TIMEOUT` is still used widely across the codebase.
Timeouts are much more complicated than a sane person would expect. Let me document some things here:
* first your proxy / load balancer / envoy / kong thing may time out before your web server does. When that happen I think nothing is returned and the request is just forever lost. The webserver may still do work, and has no way to return a response.
* flask offers no way to set a timeout, but your wsgi server does (gunicorn / nginx / ...) when that happens, it does return a proper response with an error code. Without us generating the `gunicorn` command (per #4451), people have to keep the timeouts in sync manually
* we have code on the client side that gives up if it looks like it'll never get a timeout response, I'm not sure if it's implement consistently across all "requests that may time out"
Regardless, I think we should remove the " # deprecated" comment and add some notes in there. PR coming up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org