svn commit: r1851552 - /httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c

[wr...@apache.org]

Author: wrowe
Date: Thu Jan 17 17:19:04 2019
New Revision: 1851552

URL: http://svn.apache.org/viewvc?rev=1851552&view=rev
Log:
Clarify potentially unsuccessful success results.

Curious why modules/aaa/mod_authz_dbm.c:get_dbm_grp() doesn't need the same
net changes?


Modified:
    httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c

Modified: httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c?rev=1851552&r1=1851551&r2=1851552&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c Thu Jan 17 17:19:04 2019
@@ -101,6 +101,10 @@ static apr_status_t fetch_dbm_value(cons
 
     apr_dbm_close(f);
 
+    /* NOT FOUND is not an error case; this is indicated by a NULL result.
+     * Treat all NULL lookup/error results as success for the simple case 
+     * of auth credential lookup, these are DECLINED in both cases.
+     */
     return APR_SUCCESS;
 }