[Impala-ASF-CR] IMPALA-9180 (part 2): Refactor executor list map of ExecuterBlacklist

["Qifan Chen (Code Review)" <ge...@cloudera.org>]

Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 )

Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.cc
File be/src/scheduling/executor-blacklist.cc:

http://gerrit.cloudera.org:8080/#/c/16506/5/be/src/scheduling/executor-blacklist.cc@164
PS5, Line 164: 
> No, don't need.
Yes, looks like the check is not needed since no entries in the list will be set to a state of NOT_BLACKLISTED. However, we may change this in the future, say by adding a new state enum or allowing an entry to be NOT_BLACKLISTED.



-- 
To view, visit http://gerrit.cloudera.org:8080/16506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1ae082d0e080088756af91b5b770752ca8b3aa1
Gerrit-Change-Number: 16506
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Oct 2020 13:44:41 +0000
Gerrit-HasComments: Yes