Re: [PR] [Incubator-kie-issues-1932] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

["pefernan (via GitHub)" <gi...@apache.org>]

pefernan commented on code in PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904#discussion_r2066976577


##########
kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/process/ProcessGenerationIT.java:
##########
@@ -204,7 +204,7 @@ private static void assertNodes(Node[] expected, Node[] current) {
 
     private static final BiConsumer<Node, Node> nodeAsserter = (expected, current) -> {
         assertThat(current.getId()).isEqualTo(expected.getId());
-        if (expected.getName() != null) {
+        if (expected.getName() != null && !expected.getName().trim().isEmpty()) {

Review Comment:
   Maybe we could use `StringUtils.isBlank` here like:
   ```suggestion
           if (!StringUtils.isBlank(expected.getName()) {
   ) {
   ```
   
   But I'm ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org