You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 07:45:47 UTC

[GitHub] [arrow-datafusion] PierreZ commented on issue #1864: Add a DataFusion example capable of retrieving data from a custom datasource

PierreZ commented on issue #1864:
URL: https://github.com/apache/arrow-datafusion/issues/1864#issuecomment-1055119752


   I just made [some examples](https://github.com/PierreZ/arrow-datafusion/commit/cf5aace1bcb5316dc3e49a8199bdcec61f2872cc), but I'm pretty sure we could improve them. Should I just open the PR for review? 
   
   I didn't implement my manual-index lookup I was refering at the beginning of the issue because:
   
   * It looks rather complex for an example,
   * I have no idea on how to represent it.
   
   Not sure I'm right, but a manual lookup in an index to fetch rows should:
   
   * Create a Logical Plan composed of several TableScan somehow,
   * Implements `children` correctly in the `ExecutionPlan` trait.
   * Use the data from the children to make the table scan.
   
   I did not find an example with a children, maybe it will be worth it to add another example.
   
   What do you think @houqp?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org