[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location

["Vikas Mayur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697562#action_12697562 ] 

Vikas Mayur commented on OFBIZ-2233:
------------------------------------

HI Divesh,

I did not test the patch but I would suggest you few changes

1) Form name lookupProductInventoryLocation should start with upper case letter. I would also suggest to have a different name of this form since its a list form and not a lookup form.

2) Their is no need to prefix PageTitle with the label PageTitleLookupFacilityLocation. It could be simply ProductLookupFacilityLocation. 

3) Instead of this

{code}
+        <check-permission permission="FACILITY" action="_VIEW">
+            <fail-message message="Security Error: to run findProductInventorylocations you must have the FACILITY_VIEW or FACILITY_ADMIN permission"/>
+        </check-permission>
+        <check-errors/>
{code}

permission check can be added to the service definition. It would be some thing like

{code}
<permission-service service-name="facilityGenericPermission" main-action="VIEW"/>
{code}

4) I am not sure how good is to have a permission check in the service as well (as in #3) since their is already a permission check in the screen but I think its okay as the service may be used elsewhere. 

{code}
+            <condition>
+                <if-service-permission service-name="facilityGenericPermission" main-action="VIEW"/>
+            </condition>
{code}

5) Since this is a list form and not a look up form. I think the following 
{code}
+                            <decorator-section name="search-options">
+                                <include-form name="lookupProductInventoryLocation" location="component://product/webapp/facility/lookup/FieldLookupForms.xml"/>
+                            </decorator-section>
+                        </decorator-screen>
{code}

would be 

{code}
+                            <decorator-section name="search-results">
+                                <include-form name="lookupProductInventoryLocation" location="component://product/webapp/facility/lookup/FieldLookupForms.xml"/>
+                            </decorator-section>
+                        </decorator-screen>
{code}


Thanks,
Vikas

> If Inventory Mover finds needed inventory in another location then he  can  do a quick Stock Move for that inventory from the higher shelf to the main pick location
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2233
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2233
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2233.patch, ofbiz-2233.patch
>
>
> If Inventory Mover finds needed inventory in another location then he  can  do a quick Stock Move for that inventory from the higher shelf to the main pick location. Presently in OFBiz Stock Moves  is  based on minimum quantities on each Pick/Primary.
> And  user can also  move items from one inventory location to another another inventory location in multiple steps. Not in single click. We can have  functionality in which User can move items from bulk inventory location to pick/primary inventory location  in  single  click. 
> Implementation notes:
> 1)Add form to Facility -> Stock Moves screen to specify a productId, from location, and to location in order to do a quick stock move

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.