You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/09 10:07:23 UTC
[PR] Remove invalid HTTP configuration from MCP STDIO transport [shardingsphere]
terrymanu opened a new pull request, #39387:
URL: https://github.com/apache/shardingsphere/pull/39387
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove invalid HTTP configuration from MCP STDIO transport [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39387:
URL: https://github.com/apache/shardingsphere/pull/39387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove invalid HTTP configuration from MCP STDIO transport [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39387:
URL: https://github.com/apache/shardingsphere/pull/39387#issuecomment-5230987339
### Result
**Review Result: Mergeable**
The latest public head correctly removes HTTP configuration from STDIO transport state. No blocking correctness issue survived the proof and completion gates.
### Evidence
- `MCPLaunchConfiguration.java:43-76` establishes mutually exclusive HTTP and STDIO states and guards invalid HTTP access.
- `YamlMCPLaunchConfigurationSwapper.java:48-63` constructs and serializes each transport without leaking HTTP configuration into STDIO.
- Both in-process and packaged E2E configuration helpers preserve the HTTP/STDIO distinction.
- The removed constructor has no remaining repository callers, and its introducing commit is not contained in a release tag.
- Verification passed:
- Focused changed-path tests: 47 tests.
- Full `mcp/bootstrap` tests: 294 tests.
- `test/e2e/mcp` test compilation.
- Spotless and Checkstyle: zero violations.
### Coverage
- Reviewed [PR #39387](https://github.com/apache/shardingsphere/pull/39387) head `21493b83d087f031da726afd883eceb5da2e7710`.
- Base and merge-base: `813084f6b4f89aa0956cc51e1e4e6632b23822b2`.
- GitHub’s authoritative eight-file list matched the local triple-dot scope: two production files, four unit-test files, and two E2E support files.
- Reviewed clusters: transport state model, YAML materialization, launcher consumers, and E2E configuration generation.
- Completed root-cause, blast-radius/contracts, tests/runtime/operations, and final convergence passes.
- No blocker-changing evidence gaps remain. Packaged/Docker E2E runtime execution was not performed.
- Code Correctness Review only; this is a code-scope result and CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org