You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by ykrips <gi...@git.apache.org> on 2014/09/28 03:05:31 UTC
[GitHub] tajo pull request: TAJO-1072: CLI gets stuck when wrong host/port ...
GitHub user ykrips opened a pull request:
https://github.com/apache/tajo/pull/169
TAJO-1072: CLI gets stuck when wrong host/port is provided
TajoCli should release the external resources of netty client when exceptions occur.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykrips/tajo TAJO-1072
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 9ebc6db4403144a9221e69302e21ab6ca03416a2
Author: Jihun Kang <yk...@gmail.com>
Date: 2014-09-28T00:51:30Z
TAJO-1072: CLI gets stuck when wrong host/port is provided
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1072: CLI gets stuck when wrong host/port ...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/169#issuecomment-57428358
+1
Hi @ykrips
Thank you for your contribution.
It looks good to me and it ran as expected on test cluster. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1072: CLI gets stuck when wrong host/port ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/169#issuecomment-57910098
+1
Even though TravisCI showed the unit test failure, it seems to be a temporary problem. I verified 'mvn clean install' for this patch. All unit tests are passed well. Also, I also tested the problematic case. The patch fixes the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1072: CLI gets stuck when wrong host/port ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1072: CLI gets stuck when wrong host/port ...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/169#issuecomment-57432159
Sorry guys.
I leaved comments at wrong issue. So, I removed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---