You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/09 14:25:13 UTC

[GitHub] [iceberg] nastra commented on a change in pull request #3642: build: remove slf4j-api from spark runtime projects

nastra commented on a change in pull request #3642:
URL: https://github.com/apache/iceberg/pull/3642#discussion_r765837453



##########
File path: build.gradle
##########
@@ -111,7 +111,9 @@ subprojects {
   targetCompatibility = '1.8'
 
   dependencies {
-    implementation 'org.slf4j:slf4j-api'
+    if (!(project.name.contains("spark") && project.name.contains("runtime"))) {

Review comment:
       maybe `spark-runtime` instead of just `runtime` to make sure only spark-related projects are affected?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org