You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/06/26 10:29:55 UTC
[GitHub] [airflow] amoghrajesh opened a new pull request, #32141: Do not create redis secrets for kubernetes executors
amoghrajesh opened a new pull request, #32141:
URL: https://github.com/apache/airflow/pull/32141
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Create the redis secrets only for Celery based executors and not for Kubernetes executor. This is to stay consistent with other redis elements in airflow helm charts.
closes: https://github.com/apache/airflow/issues/30420
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh closed pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh closed pull request #32141: Do not create redis secrets for kubernetes executors
URL: https://github.com/apache/airflow/pull/32141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1607281730
Could you check [this comment](https://github.com/apache/airflow/pull/30423#issuecomment-1500781210)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1608803309
@jedcunningham looping you in for some comment https://github.com/apache/airflow/pull/30423#issuecomment-1500781210. Will these changes be breaking the point that you made in your comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1633561000
Thanks Jed, I think it makes sense. I will close this issue as expected behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1633322535
Yes, my comment is still valid. I sorta think we should close that issue as "expected".
I think there are ways we could work around this, but simply adding the conditional for the executor type isn't a good path forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1607327978
I had a look at it. Looks like the secret is created for brokerUrl in such cases.
Do we need to create that secret? Not sure on the consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32141: Do not create redis secrets for kubernetes executors
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32141:
URL: https://github.com/apache/airflow/pull/32141#issuecomment-1614527510
@hussein-awala @jedcunningham following up for a review on this PR. See above comments for context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org