You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chinmay Soman <ch...@gmail.com> on 2016/02/03 06:53:25 UTC

Re: Review Request 39032: SAMZA-787: task.log4j.system should not be guessed if not configured

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39032/#review117572
-----------------------------------------------------------


Ship it!




- Chinmay Soman


On Oct. 6, 2015, 12:44 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39032/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 12:44 a.m.)
> 
> 
> Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-787
>     https://issues.apache.org/jira/browse/SAMZA-787
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-787: task.log4j.system should not be guessed if not configured
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html b42c34cf55096467ab20507d82af7d002abd8e1e 
>   docs/learn/documentation/versioned/jobs/logging.md a3bb054c0febabf2d7b6e3e18fa710f93382d744 
>   samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java 209296dd48d64159d14bf20a286d971b54fb710e 
>   samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 894845332f2a08b984c587884ed13f2854b4d492 
>   samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java f7d3cbecfb8901f5fe1a290ce9b08446ce48f4df 
>   samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java 3e812405edf1ad4fca43784b1668ab3ae6ff6475 
> 
> Diff: https://reviews.apache.org/r/39032/diff/
> 
> 
> Testing
> -------
> 
> ./bin/check-all.sh passed
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>