You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/20 21:27:10 UTC
[GitHub] [helix] dasahcc commented on a change in pull request #1019: ConnectionTimeout change to ensure HelixManager initial connection
dasahcc commented on a change in pull request #1019:
URL: https://github.com/apache/helix/pull/1019#discussion_r428316817
##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/ZkClient.java
##########
@@ -62,7 +62,10 @@
private static Logger LOG = LoggerFactory.getLogger(ZkClient.class);
public static final int DEFAULT_OPERATION_TIMEOUT = Integer.MAX_VALUE;
- public static final int DEFAULT_CONNECTION_TIMEOUT = 60 * 1000;
+ // Four times of DEFAULT_SESSION_TIMEOUT would give less 1/125 chance of initial connection
+ // to Zookeeper failure assuming one observer in the 5 observer Zookeeper Quorum is down
+ // with one DNS name configured as connection string with 3.4.13+ Zookeeper client version
+ public static final int DEFAULT_CONNECTION_TIMEOUT = 120 * 1000;
Review comment:
We already have some customers only onboard the zookeeper-api module and not for Helix. My suggestion is not change the default behavior but let it to be config change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org