You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/11/05 18:03:00 UTC

[jira] [Commented] (MPDF-47) docDescriptors of other locales than default are ignored for pdf generation

    [ https://issues.apache.org/jira/browse/MPDF-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239660#comment-16239660 ] 

Hudson commented on MPDF-47:
----------------------------

SUCCESS: Integrated in Jenkins build maven-plugins #9187 (See [https://builds.apache.org/job/maven-plugins/9187/])
[MPDF-47] use localized doc descriptor when available
Submitted by: Tim Rademacher
Applied with some modification and an additional IT (hboutemy: [http://svn.apache.org/viewvc/?view=rev&rev=1814364])
* (add) maven-pdf-plugin/src/it/descriptor
* (add) maven-pdf-plugin/src/it/descriptor/pom.xml
* (add) maven-pdf-plugin/src/it/descriptor/src
* (add) maven-pdf-plugin/src/it/descriptor/src/site
* (add) maven-pdf-plugin/src/it/descriptor/src/site/fr
* (add) maven-pdf-plugin/src/it/descriptor/src/site/fr/xdoc
* (add) maven-pdf-plugin/src/it/descriptor/src/site/fr/xdoc/foo.xml
* (add) maven-pdf-plugin/src/it/descriptor/src/site/fr/xdoc/help.xml
* (add) maven-pdf-plugin/src/it/descriptor/src/site/pdf.xml
* (add) maven-pdf-plugin/src/it/descriptor/src/site/pdf_fr.xml
* (add) maven-pdf-plugin/src/it/descriptor/src/site/xdoc
* (add) maven-pdf-plugin/src/it/descriptor/src/site/xdoc/foo.xml
* (add) maven-pdf-plugin/src/it/descriptor/src/site/xdoc/help.xml
* (add) maven-pdf-plugin/src/it/descriptor/verify.groovy
* (edit) maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/DocumentDescriptorReader.java
* (edit) maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/PdfMojo.java


> docDescriptors of other locales than default are ignored for pdf generation
> ---------------------------------------------------------------------------
>
>                 Key: MPDF-47
>                 URL: https://issues.apache.org/jira/browse/MPDF-47
>             Project: Maven PDF Plugin
>          Issue Type: Bug
>    Affects Versions: 1.1
>         Environment: Maven 2.2.1, Windows 7 (and NetBeans 6.9.1)
>            Reporter: Fabian Bahle
>            Assignee: Hervé Boutemy
>             Fix For: 1.4
>
>         Attachments: fix_locale_select.diff, pdf.xml, pdf_de.xml
>
>
> If you have a multi language maven site and you'll try to build a pdf also with multiple locales only the default pdf.xml docDescriptor will be used for generating the pdfs.
> Try following:
> Create a directory layout like:
> {noformat}
> +- src/
>    +- site/
>       +- xdoc/
>       |  +- index.xml     (some default language content)
>       |  +- help.xml     (some default language content)
>       |  +- foo.xml     (some default language content)
>       |
>       +- de/
>       |  +- xdoc/
>       |     +- index.xml     (some different content than default language)
>       |     +- help.xml     (some different content than default language)
>       |     +- foo.xml     (some different content than default language)
>       +- site.xml         (Default site descriptor)
>       +- site_de.xml      (German site descriptor)
>       +- pdf.xml          (Default pdf descriptor)
>       +- pdf_de.xml       (German pdf descriptor)
> {noformat}
> Content of pdf.xml:
> see attachment pdf.xml
> Content of pdf_de.xml:
> see attachment pdf_de.xml
> Content of pom.xml:
> {code:xml}
> ...
> 	<build>
> 		...
> 		<plugins>
> 			...
> 			<plugin>
> 				<groupId>org.apache.maven.plugins</groupId>
> 				<artifactId>maven-site-plugin</artifactId>
> 				<version>2.2</version>
> 				<configuration>
> 					<locales>en,de</locales>
> 				</configuration>
> 			</plugin>
> 			<plugin>
> 				<groupId>org.apache.maven.plugins</groupId>
> 				<artifactId>maven-pdf-plugin</artifactId>
> 				<version>1.1</version>
> 				<configuration>
> 					<outputDirectory>${project.reporting.outputDirectory}</outputDirectory>
> 					<includeReports>false</includeReports>
> 					<aggregate>true</aggregate>
> 					<locales>en,de</locales>
> 				</configuration>
> 				<executions>
> 					<execution>
> 						<id>pdf</id>
> 						<phase>site</phase>
> 						<goals>
> 							<goal>pdf</goal>
> 						</goals>
> 					</execution>
> 				</executions>
> 			</plugin>
> 		</plugins>
> 	</build>
> {code}
> If you now execute
> {noformat}
> mvn site
> {noformat}
> or
> {noformat}
> mvn pdf:pdf
> {noformat}
> and compare the two generated pdfs you'll see that the table of contents is the one from the pdf.xml in both pdfs. I guess in this case the file pdf_de.xml isn't used at anytime during the build, because the build (mvn site or mvn pdf:pdf) is also successful if you have syntax errors in the pdf_de.xml file, e.g. leave a item tag open in that file and build again.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)